Skip to content

CNV-58930: Correct the links to MTV docs #91493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

CNV-58930: Correct the links to MTV docs #91493

merged 1 commit into from
Apr 8, 2025

Conversation

jhradilek
Copy link
Contributor

@jhradilek jhradilek commented Apr 2, 2025 •
edited by dfitzmau
Loading

Version(s): 4.17+

Issue: CNV-58930

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
The Migration Toolkit for Virtualization documentation has been significantly improved since the time I wrote this procedure and has dedicated chapters for each source provider. These chapters are well organized and do a great job at outlining the migration process. I therefore do not think it is desirable to duplicate this content in the CNV docs.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025 •
edited by openshift-ci bot
Loading

@jhradilek: This pull request references CNV-58930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.17+

Issue: CNV-58930

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
The Migration Toolkit for Virtualization documentation has been significantly improved since the time I wrote this procedure and has dedicated chapters for each source provider. These chapters are well organized and do a great job at outlining the migration process. I therefore do not think it is desirable to duplicate this content in the CNV docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhradilek
Copy link
Contributor Author

/label cnv

@openshift-ci openshift-ci bot added CNV Label for all CNV PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 2, 2025 •
edited
Loading

🤖 Wed Apr 02 16:22:22 - Prow CI generated the docs preview:
https://91493--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025 •
edited by openshift-ci bot
Loading

@jhradilek: This pull request references CNV-58930 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s): 4.17+

Issue: CNV-58930

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
The Migration Toolkit for Virtualization documentation has been significantly improved since the time I wrote this procedure and has dedicated chapters for each source provider. These chapters are well organized and do a great job at outlining the migration process. I therefore do not think it is desirable to duplicate this content in the CNV docs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhradilek
CNV-58930: Corrected the links to MTV docs.
f19456a 
The Migration Toolkit for Virtualization documentation has been
significantly improved since the time I wrote this procedure and has
dedicated chapters for each source provider. These chapters are well
organized and do a great job at outlining the migration process. I
therefore do not think it is desirable to duplicate this content in the
CNV docs.
@jhradilek jhradilek force-pushed the CNV-58930-mtv-links branch from 349592b to f19456a Compare April 2, 2025 16:15
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 2, 2025

@jhradilek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jhradilek
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 7, 2025
@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 7, 2025
@mburke5678
Copy link
Contributor

mburke5678 commented Apr 7, 2025 •
edited
Loading

/lgtm I would recommend a QE review before merging/merge review.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2025
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 7, 2025
@jhradilek
Copy link
Contributor Author

Thank you. Not sure QE review is needed considering I am offloading a lot of the previously QE reviewed information on MTV docs, and all I am adding are links to a reviewed content.

@jhradilek
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 8, 2025
@dfitzmau dfitzmau added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 8, 2025
@dfitzmau
Copy link
Contributor

dfitzmau commented Apr 8, 2025

Hi @jhradilek . I do not see a QE ack on this PR. Would you be OK to get one? Just more for the version change.

@jhradilek
Copy link
Contributor Author

Hi @dfitzmau, thank you, working on getting it.

@lkladnit
Copy link

lkladnit commented Apr 8, 2025

/lgtm

@jhradilek
Copy link
Contributor Author

Thank you, Leon! @dfitzmau QE has reviewed the pull request, we should be all set to merge.

@dfitzmau dfitzmau merged commit 418695e into openshift:main Apr 8, 2025
2 checks passed
@dfitzmau
Copy link
Contributor

dfitzmau commented Apr 8, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor

dfitzmau commented Apr 8, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor

dfitzmau commented Apr 8, 2025

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #91858

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #91859

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #91860

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2025
Merged
@jhradilek jhradilek deleted the CNV-58930-mtv-links branch April 8, 2025 16:27
@dfitzmau dfitzmau removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkladnit lkladnit lkladnit approved these changes

Assignees

@mburke5678 mburke5678

@lkladnit lkladnit

Labels
branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
7 participants
@jhradilek @openshift-ci-robot @ocpdocs-previewbot @mburke5678 @dfitzmau @lkladnit @openshift-cherrypick-robot